Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add imageid output and use metadata to set digest output #569

Merged
merged 1 commit into from
Mar 14, 2022

Conversation

crazy-max
Copy link
Member

fixes #461

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

Copy link
Member

@tonistiigi tonistiigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this still needs some work maybe separate out the digest part. Only the digest from metadata is needed for the new buildx. Getting image ID output is a new feature and not time critical.

@crazy-max
Copy link
Member Author

crazy-max commented Mar 9, 2022

@tonistiigi As docker/buildx#980 and docker/buildx#989 are now merged I think we can move forward with this PR and keep imageID output. WDYT?

@crazy-max crazy-max marked this pull request as ready for review March 9, 2022 15:24
@crazy-max crazy-max marked this pull request as draft March 9, 2022 15:24
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@crazy-max crazy-max force-pushed the imageid-digest branch 4 times, most recently from bc058cb to 83a1b4f Compare March 14, 2022 13:57
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max crazy-max marked this pull request as ready for review March 14, 2022 18:31
@crazy-max crazy-max merged commit e115266 into docker:master Mar 14, 2022
@crazy-max crazy-max deleted the imageid-digest branch March 14, 2022 19:03
jglick added a commit to jglick/starter-workflows that referenced this pull request Apr 18, 2022
jglick added a commit to cloudbees-oss/inject-metadata-velero-plugin that referenced this pull request Apr 18, 2022
KendrickColeman pushed a commit to KendrickColeman/starter-workflows that referenced this pull request May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Digest output is image ID, not RepoDigest
3 participants